Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Forward pass logic on snn.synaptic neuron fix #362

Closed

Conversation

monkin77
Copy link
Contributor

@monkin77 monkin77 commented Jan 31, 2025

Fix bugs in snn.Synaptic forward pass. Mentioned in issues #358 #350 #349.

  1. Synaptic Current was being assigned to the wrong variable (self.syn = self.mem`)
  2. The reset mechanism was not referencing the neuron's membrane potential variable properly (using mem instead of self.mem)

Pull Request #360 also takes care of the first issue.

Verified

This commit was signed with the committer’s verified signature.
jrjohnson Jon Johnson
@monkin77 monkin77 marked this pull request as draft January 31, 2025 17:14
@monkin77 monkin77 closed this Jan 31, 2025
@monkin77 monkin77 reopened this Jan 31, 2025
@monkin77 monkin77 changed the title Fix: Forward pass logic on snn.synaptic neuron Fix: Forward pass logic on snn.synaptic neuron #358 Feb 2, 2025
@monkin77 monkin77 changed the title Fix: Forward pass logic on snn.synaptic neuron #358 Fix: Forward pass logic on snn.synaptic neuron fix Feb 2, 2025
@monkin77 monkin77 closed this Feb 2, 2025
@monkin77 monkin77 deleted the fix/forward-synaptic-neuron branch February 2, 2025 20:17
@stevenabreu7
Copy link
Collaborator

(seems to be closed in favor of #363)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants